Skip to content

Fix meeting stop timeout diagnostics snapshot#642

Merged
r3dbars merged 1 commit into
mainfrom
codex/fix-meeting-stop-timeout-snapshot
May 2, 2026
Merged

Fix meeting stop timeout diagnostics snapshot#642
r3dbars merged 1 commit into
mainfrom
codex/fix-meeting-stop-timeout-snapshot

Conversation

@r3dbars
Copy link
Copy Markdown
Owner

@r3dbars r3dbars commented May 2, 2026

Summary

  • use the recording stop snapshot for stop-timeout diagnostics after the meeting stop refactor

Verification

  • bash run-tests.sh
  • bash build.sh

@r3dbars r3dbars merged commit bf4605f into main May 2, 2026
@r3dbars r3dbars deleted the codex/fix-meeting-stop-timeout-snapshot branch May 2, 2026 02:48
Copy link
Copy Markdown
Owner Author

r3dbars commented May 2, 2026

Verdict: APPROVE

Summary: This PR fixes two stale references in the recording_stop_timeout diagnostics path inside MeetingSessionController.stopRecording(...). After a prior refactor moved recording metadata into RecordingStopSnapshot, this one recordStall call site was missed and still referenced the now-removed finalRecordingDuration and recordingTrigger locals. The fix aligns it with every other usage in the method.

Blockers: None.

Should fix: None.

Nits: None.

What looks good:

  • Minimal, surgical fix — two lines changed, zero risk of side effects.
  • The snapshot is already constructed at the top of stopRecording (line 519) and used consistently everywhere else in the method; this just brings the last holdout in line.
  • PR description is clear and verification steps are appropriate.

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant